This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] split up epiphany's md_assemble ()
- From: Trevor Saunders <tbsaunde at tbsaunde dot org>
- To: Alan Modra <amodra at gmail dot com>
- Cc: tbsaunde+binutils at tbsaunde dot org, binutils at sourceware dot org
- Date: Wed, 2 Mar 2016 23:04:15 -0500
- Subject: Re: [PATCH] split up epiphany's md_assemble ()
- Authentication-results: sourceware.org; auth=none
- References: <1456689667-17479-1-git-send-email-tbsaunde+binutils at tbsaunde dot org> <20160302071345 dot GZ10657 at bubble dot grove dot modra dot org>
On Wed, Mar 02, 2016 at 05:43:45PM +1030, Alan Modra wrote:
> On Sun, Feb 28, 2016 at 03:01:07PM -0500, tbsaunde+binutils@tbsaunde.org wrote:
> > * gas/config/tc-epiphany.c (md_assemble): Adjust.
> > (epiphany_assemble): New function.
>
> OK, but
>
> > +static void
> > + epiphany_assemble (const char *str)
> > + {
>
> please fix the formatting here, and move md_assemble after
> epiphany_assemble so the forward declaration is not needed.
Sure, the only reason I did it that way was to make the diff easier to
read.
I don't have commit access so can somebody please commit these for me
if I post fixed patches tomorrow?
thanks!
Trev
>
> --
> Alan Modra
> Australia Development Lab, IBM