This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] add section alignment/size hooks to gold plugin interface, revised
- From: Than McIntosh <thanm at google dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Cary Coutant <ccoutant at gmail dot com>, Binutils <binutils at sourceware dot org>
- Date: Wed, 9 Mar 2016 11:34:11 -0500
- Subject: Re: [PATCH] add section alignment/size hooks to gold plugin interface, revised
- Authentication-results: sourceware.org; auth=none
- References: <CA+Ur55GWa0S4GPkOvGPZipqFw8tuVaRx6vNEntL64FmYKuWcDA at mail dot gmail dot com> <CAJimCsHWeoAA3kCAH7HkBAvwNQY0b2smyXn4HEvzEvUhGkdGpA at mail dot gmail dot com> <CAMe9rOoapon=cR5-1jSs0uypESBrt9RZzDDvJDZMgAf4g5OUMw at mail dot gmail dot com> <CAJimCsFcrbP2pGQUbDU8mx9jF_6z2YduXnjX3Wh7Gvrt40k+LA at mail dot gmail dot com> <CAMe9rOqmEmqLWy=Q9ryKaxE6fBAf8buEFO-4xrEjx+h+vMc2uw at mail dot gmail dot com> <CAMe9rOqVuzqMrVGXQHGHOw_X8KQ6+Bfgw9=04E4FUTy6i2et8g at mail dot gmail dot com> <CAMe9rOr1K+v24JdNfaiyn0X4YOBiXucPdL+3nmX2_wcxASQjiw at mail dot gmail dot com>
Thanks for taking care of that. Workaround looks good to me.
Regards, Than
On Wed, Mar 9, 2016 at 11:32 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, Mar 9, 2016 at 8:16 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Wed, Mar 9, 2016 at 8:00 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>> On Fri, Mar 4, 2016 at 2:22 PM, Cary Coutant <ccoutant@gmail.com> wrote:
>>>>> I checked in this:
>>>>>
>>>>> commit 3f1f41f55f2fa5d390e57074477b6407302c8c46
>>>>> Author: H.J. Lu <hjl.tools@gmail.com>
>>>>> Date: Fri Mar 4 08:28:12 2016 -0800
>>>>>
>>>>> Add missing ChangeLog entries for commit 82838
>>>>>
>>>>> Fix gold/testsuite/plugin_layout_with_alignment.sh permission.
>>>>
>>>> Thanks. I've also pushed this patch to fix a few "2015" entries that
>>>> should have been "2016".
>>>>
>>>
>>> The test failed with GCC 4.2:
>>>
>>> FAIL: plugin_layout_with_alignment.sh (exit: 1)
>>> ===============================================
>>>
>>> incorrect ordering:
>>> was: bss_item1 bss_item2 bss_item3 bss_item4
>>> should have been: bss_item3 bss_item1 bss_item4 bss_item2
>>>
>>> Does GCC 4.2 support plugin?
>>
>> GCC 4.2 generates
>>
>>
>> [10] .data.v1_a2 PROGBITS 0000000000000000 000264
>> 000002 00 WA 0 0 2
>> [11] .data.v2_a1 PROGBITS 0000000000000000 000266
>> 000001 00 WA 0 0 1
>> [12] .data.v3_a8 PROGBITS 0000000000000000 000268
>> 000008 00 WA 0 0 8
>> [13] .data.v4_a1 PROGBITS 0000000000000000 000270
>> 000003 00 WA 0 0 1
>> [14] .bss.v1_a2 NOBITS 0000000000000000 000274
>> 000002 00 WA 0 0 2
>> [15] .bss.v2_a1 NOBITS 0000000000000000 000274
>> 000001 00 WA 0 0 1
>> [16] .bss.v3_a8 NOBITS 0000000000000000 000278
>> 000008 00 WA 0 0 8
>> [17] .bss.v4_a1 NOBITS 0000000000000000 000278
>> 000003 00 WA 0 0 1
>>
>> and GCC 5 generates
>>
>> [ 4] .rodata.v1_a2 PROGBITS 0000000000000000 000040 000002
>> 00 A 0 0 2
>> [ 5] .rodata.v2_a1 PROGBITS 0000000000000000 000042
>> 000001 00 A 0 0 1
>> [ 6] .rodata.v3_a8 PROGBITS 0000000000000000 000048
>> 000008 00 A 0 0 8
>> [ 7] .rodata.v4_a1 PROGBITS 0000000000000000 000050
>> 000007 00 A 0 0 1
>> [ 8] .data.v1_a2 PROGBITS 0000000000000000 000058
>> 000002 00 WA 0 0 2
>> [ 9] .data.v2_a1 PROGBITS 0000000000000000 00005a
>> 000001 00 WA 0 0 1
>> [10] .data.v3_a8 PROGBITS 0000000000000000 000060
>> 000008 00 WA 0 0 8
>> [11] .data.v4_a1 PROGBITS 0000000000000000 000068
>> 000003 00 WA 0 0 1
>> [12] .bss.v1_a2 NOBITS 0000000000000000 00006c
>> 000002 00 WA 0 0 2
>> [13] .bss.v2_a1 NOBITS 0000000000000000 00006c
>> 000001 00 WA 0 0 1
>> [14] .bss.v3_a8 NOBITS 0000000000000000 000070
>> 000008 00 WA 0 0 8
>> [15] .bss.v4_a1 NOBITS 0000000000000000 000070
>> 000003 00 WA 0 0 1
>>
>> I got
>>
>> Expected 12 sections, found 8 sections
>>
>> with GCC 4.2.
>>
>
> I am checking this workaround.
>
> --
> H.J.