This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] replace some raw xmalloc / xrealloc with the XNEW* macros


Hi Trevor,

> gas/ChangeLog:
> 2016-03-19  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
> 
> 	* listing.c (listing_message): Use XNEW style allocation macros.
> 	* read.c (read_a_source_file): Likewise.
> 	(read_symbol_name): Likewise.
> 	(s_mri_common): Likewise.
> 	(assign_symbol): Likewise.
> 	(s_reloc): Likewise.
> 	(emit_expr_with_reloc): Likewise.
> 	(s_incbin): Likewise.
> 	(s_include): Likewise.
> 	* sb.c (sb_build): Likewise.
> 	(sb_check): Likewise.

Approved - please apply.

Note - I find it irksome that the type has to be specified in these
macros, rather than extract from the variable being (re)allocated,
but I could not think of any clean, non-GCC specific, way of 
achieving this.  So please go ahead with the patch as is.

Cheers
  Nick



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]