This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PUSHED/OBV] opcodes/arc/nps: Fix some operand flags
- From: Claudiu Zissulescu <claziss at gmail dot com>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Thu, 31 Mar 2016 15:26:35 +0200
- Subject: Re: [PUSHED/OBV] opcodes/arc/nps: Fix some operand flags
- Authentication-results: sourceware.org; auth=none
- References: <1459429941-9993-1-git-send-email-andrew dot burgess at embecosm dot com>
This is fine also.
Cheers,
Claudiu
On Thu, Mar 31, 2016 at 3:12 PM, Andrew Burgess
<andrew.burgess@embecosm.com> wrote:
> Some operands accidentally had the ARC_OPERAND_NCHK flag (due to copy &
> paste mistake), meaning the operand value was skipping the overflow
> check before being inserted. This commit removes the unwanted flags.
>
> opcodes/ChangeLog:
>
> * arc-opc.c (arc_operands): Fix operand flags for NPS_R_DST, and
> NPS_R_SRC1.
> ---
> opcodes/ChangeLog | 5 +++++
> opcodes/arc-opc.c | 4 ++--
> 2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/opcodes/arc-opc.c b/opcodes/arc-opc.c
> index 24d6f6b..231ef4b 100644
> --- a/opcodes/arc-opc.c
> +++ b/opcodes/arc-opc.c
> @@ -1311,10 +1311,10 @@ const struct arc_operand arc_operands[] =
> { 3, 21, 0, ARC_OPERAND_IR | ARC_OPERAND_NCHK, insert_nps_3bit_src2, extract_nps_3bit_src2 },
>
> #define NPS_R_DST (NPS_R_SRC2_3B + 1)
> - { 6, 21, 0, ARC_OPERAND_IR | ARC_OPERAND_NCHK, NULL, NULL },
> + { 6, 21, 0, ARC_OPERAND_IR, NULL, NULL },
>
> #define NPS_R_SRC1 (NPS_R_DST + 1)
> - { 6, 21, 0, ARC_OPERAND_IR | ARC_OPERAND_DUPLICATE | ARC_OPERAND_NCHK, NULL, NULL },
> + { 6, 21, 0, ARC_OPERAND_IR | ARC_OPERAND_DUPLICATE, NULL, NULL },
>
> #define NPS_BITOP_DST_POS (NPS_R_SRC1 + 1)
> { 5, 5, 0, ARC_OPERAND_UNSIGNED, 0, 0 },
> --
> 2.5.1
>