This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH] bfin: simplify current_inputline
- From: tbsaunde+binutils at tbsaunde dot org
- To: binutils at sourceware dot org
- Cc: Trevor Saunders <tbsaunde+binutils at tbsaunde dot org>
- Date: Sat, 2 Apr 2016 14:12:19 -0400
- Subject: [PATCH] bfin: simplify current_inputline
- Authentication-results: sourceware.org; auth=none
From: Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
Hi,
Its not used for anything outside of md_assemble () so it doesn't need to be
extern. While we are there we can replace free () and xmalloc () with
XRESIZEVEC which should be faster.
built and regtested a cross to bfin-elf, ok?
Trev
gas/ChangeLog:
2016-04-02 Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
* config/bfin-parse.y (current_inputline): Remove definition.
* config/tc-bfin.c (md_assemble): Simplify use of current_inputline.
---
gas/config/bfin-parse.y | 1 -
gas/config/tc-bfin.c | 6 ++----
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/gas/config/bfin-parse.y b/gas/config/bfin-parse.y
index be53280..26070c1 100644
--- a/gas/config/bfin-parse.y
+++ b/gas/config/bfin-parse.y
@@ -160,7 +160,6 @@ static Expr_Node *unary (Expr_Op_Type, Expr_Node *);
static void notethat (const char *, ...);
-char *current_inputline;
extern char *yytext;
int yyerror (const char *);
diff --git a/gas/config/tc-bfin.c b/gas/config/tc-bfin.c
index caa89c6..4f9ad7e 100644
--- a/gas/config/tc-bfin.c
+++ b/gas/config/tc-bfin.c
@@ -485,20 +485,18 @@ void
md_assemble (char *line)
{
char *toP = 0;
- extern char *current_inputline;
int size, insn_size;
struct bfin_insn *tmp_insn;
size_t len;
static size_t buffer_len = 0;
+ static char *current_inputline;
parse_state state;
len = strlen (line);
if (len + 2 > buffer_len)
{
- if (buffer_len > 0)
- free (current_inputline);
buffer_len = len + 40;
- current_inputline = xmalloc (buffer_len);
+ current_inputline = XRESIZEVEC (char, current_inputline, buffer_len);
}
memcpy (current_inputline, line, len);
current_inputline[len] = ';';
--
2.1.4