This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCHv2 2/3] bfd/arc: Rename enum entries to avoid conflicts
- From: Nick Clifton <nickc at redhat dot com>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>, binutils at sourceware dot org
- Cc: Claudiu dot Zissulescu at synopsys dot com, Cupertino dot Miranda at synopsys dot com, noamca at mellanox dot com
- Date: Wed, 13 Apr 2016 14:34:30 +0100
- Subject: Re: [PATCHv2 2/3] bfd/arc: Rename enum entries to avoid conflicts
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1460458691 dot git dot andrew dot burgess at embecosm dot com> <8181b22162809916157ac2d6d38f50840371d3c5 dot 1460458691 dot git dot andrew dot burgess at embecosm dot com>
Hi Andrew,
> bfd/ChangeLog:
>
> * elf32-arc.c (tls_got_entries): Add 'TLS_GOT_' prefix to all
> entries.
> (elf_arc_relocate_section): Update enum uses.
> (elf_arc_check_relocs): Likewise.
> (elf_arc_finish_dynamic_symbol): Likewise.
Approved - please apply. But ...
> - + (entry->existing_entries == MOD_AND_OFF ? 4 : 0));
> + + (entry->existing_entries ==TLS_GOT_MOD_AND_OFF ? 4 : 0));
You need a space between the == and the TLS_GOT_MOD_AND_OFF.
Cheers
Nick