This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH 1/2] LD/testsuite: Add STB_GNU_UNIQUE cross-linker test
- From: "Maciej W. Rozycki" <macro at imgtec dot com>
- To: <binutils at sourceware dot org>
- Date: Wed, 4 May 2016 01:46:10 +0100
- Subject: [PATCH 1/2] LD/testsuite: Add STB_GNU_UNIQUE cross-linker test
- Authentication-results: sourceware.org; auth=none
Some targets are only really, or at least regularly, regression-tested
in a crossed configuration. Currently we only have native compiled test
cases for the STB_GNU_UNIQUE feature in the linker test suite. This is
nice, covering run-time semantics even, but quite often not run at all.
Consequently a regression may remain unnoticed for long.
Add a simple test case then to provide basic linker coverage with no
need for a compiler or a native toolchain.
ld/
* testsuite/ld-unique/unique.d: New test.
* ld/testsuite/ld-unique/unique.exp: Run the new test. Adjust
messages for compiled tests.
---
Hi,
No regressions across my usual test target selection (currently 153,
including 117 non-MIPS ones). OK to apply?
Maciej
binutils-ld-stb-gnu-unique-test.diff
Index: binutils/ld/testsuite/ld-unique/unique.d
===================================================================
--- /dev/null 1970-01-01 00:00:00.000000000 +0000
+++ binutils/ld/testsuite/ld-unique/unique.d 2016-04-30 01:16:25.395609668 +0100
@@ -0,0 +1,9 @@
+#ld: -r
+#readelf: -sh
+#name: Linker setting GNU OSABI on STB_GNU_UNIQUE symbol (PR 10549)
+
+#...
+ *OS/ABI: +UNIX - GNU
+#...
+ *[0-9]+: +[0-9a-f]+ +[0-9]+ +OBJECT +UNIQUE +DEFAULT +[0-9]+ a
+#pass
Index: binutils/ld/testsuite/ld-unique/unique.exp
===================================================================
--- binutils.orig/ld/testsuite/ld-unique/unique.exp 2016-04-30 01:16:25.334034718 +0100
+++ binutils/ld/testsuite/ld-unique/unique.exp 2016-04-30 01:16:25.402711134 +0100
@@ -42,19 +42,21 @@ if {!(([istarget "i?86-*-*"]
return
}
+run_dump_test "unique"
+
# We need a native system. FIXME: Strictly speaking this
# is not true, we just need to know how to create a fully
# linked executable, including the C and Z libraries, using
# the linker that is under test.
if ![isnative] {
- verbose "UNIQUE tests not run - not a native toolchain"
+ verbose "UNIQUE compiled tests not run - not a native toolchain"
return
}
# We need a working compiler. (Strictly speaking this is
# not true, we could use target specific assembler files).
if { [which $CC] == 0 } {
- verbose "UNIQUE tests not run - no compiler available"
+ verbose "UNIQUE compiled tests not run - no compiler available"
return
}