This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[committed] SH64/GAS: Fix a -Wwrite-strings build failure
- From: "Maciej W. Rozycki" <macro at imgtec dot com>
- To: Trevor Saunders <tbsaunde+binutils at tbsaunde dot org>
- Cc: <binutils at sourceware dot org>, Alexandre Oliva <aoliva at redhat dot com>, Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>
- Date: Sun, 15 May 2016 23:30:19 +0100
- Subject: [committed] SH64/GAS: Fix a -Wwrite-strings build failure
- Authentication-results: sourceware.org; auth=none
Fix a commit 6757cf57697d ("enable -Wwrite-strings for gas") regression.
gas/
* config/tc-sh64.c (shmedia_check_limits): Constify `msg'.
---
Applied as obvious.
Trevor, would you please run wide testing when making changes like your
offending commit, which affect many targets? While I do appreciate your
janitorial work introducing build failures breaks bisection and generic
testing run by other people, so I will appreciate your work even more if
you try and keep things working.
Maciej
binutils-sh64-gas-write-strings.diff
Index: binutils/gas/config/tc-sh64.c
===================================================================
--- binutils.orig/gas/config/tc-sh64.c 2016-05-15 21:19:51.000000000 +0100
+++ binutils/gas/config/tc-sh64.c 2016-05-15 21:25:35.007019060 +0100
@@ -1473,7 +1473,7 @@ shmedia_check_limits (offsetT *valp, bfd
{
offsetT val = *valp;
- char *msg = NULL;
+ const char *msg = NULL;
switch (reloc)
{