This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] change the type of some fields to bfd_reloc_code_real_type


On Tue, May 17, 2016 at 11:25:01PM -0400, tbsaunde+binutils@tbsaunde.org wrote:
> 	* config/tc-dlx.c (struct machine_it): change the type of a field from
> 	int to bfd_reloc_code_real_type.
> 	* config/tc-tic4x.c: Likewise.

OK, but

> --- a/gas/config/tc-tic4x.c
> +++ b/gas/config/tc-tic4x.c
> @@ -124,7 +124,7 @@ typedef struct tic4x_insn
>      unsigned int nchars;	/* This is always 4 for the C30.  */
>      unsigned long opcode;	/* Opcode number.  */
>      expressionS exp;		/* Expression required for relocation.  */
> -    int reloc;			/* Relocation type required.  */
> +    bfd_reloc_code_real_type reloc;			/* Relocation type required.  */

Please fix overly long line.

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]