This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH][gold] Mips: Fix emitting .reginfo section.


> +  // Return whether there is a .reginfo section.
> +  bool
> +  has_reginfo_section() const
> +  { return has_reginfo_section_; }
> 
> Need "this->".

Done.

> @@ -7689,8 +7671,6 @@ Mips_output_section_reginfo<size,
> big_endian>::do_write(Output_file* of)
>    // Write the gp value.
>    elfcpp::Swap<size, big_endian>::writeval(view + 20,
>                                             this->target_->gp_value());
> -
> -  of->write_output_view(offset, data_size, view);
> 
> Why did you remove the call to write_output_view?

I didn't know that this will be implemented in the future.

Thanks for review!

Regards,
Vladimir.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]