This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH][gold] Mips: Fix emitting .reginfo section.
- From: Vladimir Radosavljevic <Vladimir dot Radosavljevic at imgtec dot com>
- To: Cary Coutant <ccoutant at gmail dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, Petar Jovanovic <Petar dot Jovanovic at imgtec dot com>
- Date: Mon, 23 May 2016 15:57:31 +0000
- Subject: RE: [PATCH][gold] Mips: Fix emitting .reginfo section.
- Authentication-results: sourceware.org; auth=none
- References: <3060420525346945A0ADBD567348A917237414CA at BADAG02 dot ba dot imgtec dot org>,<CAJimCsFe11aHmvTpP+yQgy8s2kRd8O7qYkRs8+UrUM0y+0DQNw at mail dot gmail dot com>
> + // Return whether there is a .reginfo section.
> + bool
> + has_reginfo_section() const
> + { return has_reginfo_section_; }
>
> Need "this->".
Done.
> @@ -7689,8 +7671,6 @@ Mips_output_section_reginfo<size,
> big_endian>::do_write(Output_file* of)
> // Write the gp value.
> elfcpp::Swap<size, big_endian>::writeval(view + 20,
> this->target_->gp_value());
> -
> - of->write_output_view(offset, data_size, view);
>
> Why did you remove the call to write_output_view?
I didn't know that this will be implemented in the future.
Thanks for review!
Regards,
Vladimir.