This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
libiberty: Don't needlessly clear xmemdup allocated memory
- From: Alan Modra <amodra at gmail dot com>
- To: gcc-patches at gcc dot gnu dot org, binutils at sourceware dot org
- Date: Sat, 28 May 2016 22:42:23 +0930
- Subject: libiberty: Don't needlessly clear xmemdup allocated memory
- Authentication-results: sourceware.org; auth=none
OK to apply?
* xmemdup.c (xmemdup): Use xmalloc rather than xcalloc.
diff --git a/libiberty/xmemdup.c b/libiberty/xmemdup.c
index aa56f0b..4602afd 100644
--- a/libiberty/xmemdup.c
+++ b/libiberty/xmemdup.c
@@ -1,4 +1,4 @@
-/* xmemdup.c -- Duplicate a memory buffer, using xcalloc.
+/* xmemdup.c -- Duplicate a memory buffer, using xmalloc.
This trivial function is in the public domain.
Jeff Garzik, September 1999. */
@@ -34,6 +34,8 @@ allocated, the remaining memory is zeroed.
PTR
xmemdup (const PTR input, size_t copy_size, size_t alloc_size)
{
- PTR output = xcalloc (1, alloc_size);
+ PTR output = xmalloc (alloc_size);
+ if (alloc_size > copy_size)
+ memset ((char *) output + copy_size, 0, alloc_size - copy_size);
return (PTR) memcpy (output, input, copy_size);
}
--
Alan Modra
Australia Development Lab, IBM