This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH 7/8] Remove unneeded checks on type lengths.
- From: John Baldwin <jhb at FreeBSD dot org>
- To: gdb-patches at sourceware dot org, binutils at sourceware dot org
- Date: Sat, 11 Jun 2016 13:48:34 -0700
- Subject: [PATCH 7/8] Remove unneeded checks on type lengths.
- Authentication-results: sourceware.org; auth=none
- References: <1465678115-58170-1-git-send-email-jhb at FreeBSD dot org>
Type lengths are unsigned, so are always greater than zero. A check
against the length of 'tgt_type' is retained to prevent dividing by zero.
---
gdb/ChangeLog | 4 ++++
gdb/v850-tdep.c | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index d188af9..4c4389d 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2016-06-11 John Baldwin <jhb@FreeBSD.org>
+ * v850-tdep.c (v850_use_struct_convention): Trim type length checks.
+
+2016-06-11 John Baldwin <jhb@FreeBSD.org>
+
* tui/tui-stack.c (tui_show_frame_info): Fix type mismatch.
2016-06-11 John Baldwin <jhb@FreeBSD.org>
diff --git a/gdb/v850-tdep.c b/gdb/v850-tdep.c
index 612eec3..0b50580 100644
--- a/gdb/v850-tdep.c
+++ b/gdb/v850-tdep.c
@@ -559,7 +559,7 @@ v850_use_struct_convention (struct gdbarch *gdbarch, struct type *type)
if (TYPE_CODE (fld_type) == TYPE_CODE_ARRAY)
{
tgt_type = TYPE_TARGET_TYPE (fld_type);
- if (TYPE_LENGTH (fld_type) >= 0 && TYPE_LENGTH (tgt_type) >= 0
+ if (TYPE_LENGTH (tgt_type) > 0
&& TYPE_LENGTH (fld_type) / TYPE_LENGTH (tgt_type) > 2)
return 1;
}
--
2.7.0