This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: MALLOC_PERTURB_=1 test results


On Tue, May 31, 2016 at 08:33:29PM +0930, Alan Modra wrote:
> Setting MALLOC_PERTURB_ showed a failure of objcopy --add-symbol,
> fixed with the following patch.
> 
> These two also showed up:
> arm-linuxeabi  +FAIL: STM32L4XX erratum : LDM cannot be patched when LDM is too far from veneer section
> epiphany-elf  +FAIL: badrelax
> Both are uninitialized section contents.
> 
> 	* objcopy.c: Formatting, whitespace throughout.
> 	(copy_main): Init newsym->othersym.
> 	(parse_symflags): Make len a size_t.  Adjust uses.

I'm committing this to the branch.

	* objcopy.c (copy_main): Init newsym->othersym.

diff --git a/binutils/objcopy.c b/binutils/objcopy.c
index 4a9f043..7feddb4 100644
--- a/binutils/objcopy.c
+++ b/binutils/objcopy.c
@@ -4096,6 +4096,7 @@ copy_main (int argc, char *argv[])
 	      }
 
 	    t = strchr (t + 1, ',');
+	    newsym->othersym = NULL;
 	    if (t)
 	      newsym->flags = parse_symflags (t+1, &newsym->othersym);
 	    else

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]