This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix grammar in bfd warning message

Hi Guys,

>> I don't think this change is an improvement.  In the original phrasing
>> "to" was intended to be a preposition: it's complaining that it is
>> writing a section "to" a location in the file whose offset is so large
>> that it doesn't fit in a signed int.  With your change the sentence no
>> longer has a preposition which breaks the grammar.

  *Doh* - this happens when I start reviewing patches before having my first cup of tea of the day...

> I also agree with Phil Blundell on his rewording to remove the ambiguity, i.e. use "at".

  Fair enough - patch checked in.

Cheers
  Nick
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]