This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/3] [ARC] Implement NPS-400 PMU Instructions

From: Claudiu Zissulescu <claziss at gmail dot com>
To: Graham Markall <graham dot markall at embecosm dot com>, binutils at sourceware dot org
Cc: claudiu dot zissulescu at synopsys dot com
Date: Fri, 22 Jul 2016 18:41:18 +0200
Subject: Re: [PATCH 3/3] [ARC] Implement NPS-400 PMU Instructions
Authentication-results: sourceware.org; auth=none
References: <cover.1469194931.git.graham.markall@embecosm.com> <81b1cad086f99d4d7f102f6a156a25df07d8c67c.1469194931.git.graham.markall@embecosm.com>

Hi,

> @@ -55,6 +55,7 @@ typedef enum

      LOGICAL,
      MEMORY,
      NET,
+    PMU,

Using older compilers this last comma may trigger a warning. You mayremove it if you please.

+/****                        PMU Instructions                         ****/


This is not a gnu-like comment. Please use dot and 2 spaces.


Best,
Claudiu

References:
- [PATCH 0/3] [ARC] Begin implementing NPS-400 Accelerator instructions
  - From: Graham Markall
- [PATCH 3/3] [ARC] Implement NPS-400 PMU Instructions
  - From: Graham Markall

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]