This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/3] [ARC] Implement NPS-400 BMU instructions


Hi Claudiu,

Many thanks for the fast review.

On 22/07/16 17:43, Claudiu Zissulescu wrote:
>> +
>> +/****                        BMU Instructions                        
>> ****/
>> +
> This is not a gnu like comment, please fix it.
>
> This is not a gnu-like comment. Please use dot and 2 spaces.

There are quite a few instances of this comment format, and I'd prefer
to correct them all rather than just the two that are introduced by
these patches, which I'll do. However, I'd like to check exactly what
you mean by "Please use dot and 2 spaces." to save going back-and-forth
more than once - did you mean that they should follow this format:

/* BMU Instructions.  */

? If I have misunderstood, could you provide me with an example of the
preferred format please?


Many thanks,
Graham.

Attachment: signature.asc
Description: OpenPGP digital signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]