Re: [PATCH] PR gold/17704

[Sriraman Tallam <tmsriram at google dot com>]

On Fri, Aug 12, 2016 at 8:33 AM, Cary Coutant <ccoutant@gmail.com> wrote:
>>> PR gold/17704
>>> * icf.cc (match_sections): Add new parameter section_addraligns.
>>> Check section alignment and keep the section with the strictest
>>> alignment.
>>> (find_identical_sections): New local variable section_addraligns.
>>> Store each section's alignment.
>>> * testsuite/pr17704a_test.s: New file.
>>> * testsuite/Makefile.am (pr17704a_test): New test.
>>> * testsuite/Makefile.in: Regenerate.
>
> +  (void)section_addraligns;
>
> This shouldn't be necessary, but if it really is, I'd prefer to use
> ATTRIBUTE_UNUSED on the parameter.
>
> Also, I get this when trying to apply the patch:
>
> patch: **** malformed patch at line 146: diff --git
> a/gold/testsuite/pr17704a_test.s b/gold/testsuite/pr17704a_test.s
>
> I think you may have deleted too much when deleting the hunks for
> testsuite/Makefile.in.

Sorry for the late response, fixed both problems. Patch attached.

Thanks
Sri

>
> -cary

Attachment: icf_section_alignment.txt
Description: Text document