This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] [SPARC] gas: detect DCTI couples in sparc
- From: jose dot marchesi at oracle dot com (Jose E. Marchesi)
- To: Nick Clifton <nickc at redhat dot com>
- Cc: binutils at sourceware dot org
- Date: Wed, 14 Sep 2016 15:43:41 +0200
- Subject: Re: [PATCH] [SPARC] gas: detect DCTI couples in sparc
- Authentication-results: sourceware.org; auth=none
- References: <87y42yd1v9.fsf@oracle.com> <d1c0a7ea-eeb5-bcd0-042a-6249fbd98549@redhat.com>
> +/* Non-zero if as should generate a warning if an unpredictable DCTI
> + (delayed control transfer instruction) couple is found. */
> +static int dcti_couples_detect;
For clarity, I suggest that you change "as" to "the assembler" in the
comment above.
Ok.
Also - is there any particular reason why you used the "int" type for
this variable, when "bfd_boolean" might have been more appropriate ?
Not really, I am just following the same style than in the rest of
tc-sparc.c, where bfd_booleans are unheard-of :)