This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Solving symbols from different shared objects?
- From: Cary Coutant <ccoutant at gmail dot com>
- To: Han Shen <shenhan at google dot com>
- Cc: binutils <binutils at sourceware dot org>, Eric Christopher <echristo at google dot com>, Jing Yu <jingyu at google dot com>, Jeff Bailey <jeffbailey at google dot com>, Brooks Moses <bmoses at google dot com>
- Date: Mon, 26 Sep 2016 12:03:20 -0700
- Subject: Re: Solving symbols from different shared objects?
- Authentication-results: sourceware.org; auth=none
- References: <CACkGtrjV8qoNne9YoTx4Kcx=NoT5=GfWmrbCTbKUOiBw1XydQg@mail.gmail.com>
> diff --git a/gold/symtab.cc b/gold/symtab.cc
> index b31794a..cdeef7f 100644
> --- a/gold/symtab.cc
> +++ b/gold/symtab.cc
> @@ -881,7 +881,7 @@
> Symbol_table::define_default_version(Sized_symbol<size>* sym,
> && sym->is_from_dynobj())
> ;
> else if (pdef->second->is_from_dynobj()
> - && sym->is_from_dynobj()
> + && sym->is_from_dynobj() && pdef->second->is_defined()
> && pdef->second->object() != sym->object())
> ;
> else
>
> Do you think this is a a reasonable fix?
Yes, this is actually the exact fix I was already testing. I'll go
ahead and commit it.
Thanks!
-cary