This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH MIPS] Work around Bash 4.2 bug
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: Ludovic Courtès <ludo at gnu dot org>
- Cc: binutils at sourceware dot org
- Date: Fri, 30 Sep 2016 06:23:18 -0400 (EDT)
- Subject: Re: [PATCH MIPS] Work around Bash 4.2 bug
- Authentication-results: sourceware.org; auth=none
- References: <87d1jlrar1.fsf@gnu.org>
On Fri, 30 Sep 2016, Ludovic Courtès wrote:
> Hello,
>
> The patch below works around the Bash 4.2 bug described at
> <http://ftp.gnu.org/gnu/bash/bash-4.2-patches/bash42-007>.
> * emulparams/elf32bmipn32-defs.sh: Shift quote of
> "x$EMULATION_NAME" to the left to work around
> <http://ftp.gnu.org/gnu/bash/bash-4.2-patches/bash42-007>.
>
>
> -case x"$EMULATION_NAME" in
> +case "x$EMULATION_NAME" in
> xelf32*n32*) ELFSIZE=32 ;;
Random comment from the sideline: pretty please add a comment
regarding the bug workaround *on top of the actual changed code*
(remember: the "why" goes in the code, not in the changelog), so
it has a better chance of not being inadvertently reverted but
instead propagating elsewhere.
brgds, H-P