This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Speedup-objdump-in-processing-of-source-line-information
- From: Igor Tsimbalist <tigor dot tools at gmail dot com>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: binutils at sourceware dot org, "H.J. Lu" <hjl dot tools at gmail dot com>
- Date: Mon, 14 Nov 2016 10:51:44 +0700
- Subject: Re: [PATCH] Speedup-objdump-in-processing-of-source-line-information
- Authentication-results: sourceware.org; auth=none
- References: <CACwv7=hErY9d+EdntxFrhMQfhk9sERLCDQnfUMBPwjpM85Ue+g@mail.gmail.com> <0f56a46d-e865-11d7-cb72-158f5bcda14c@redhat.com>
Hi Nick,
I was on vacation last week thus no reply :).
Thank you for reviewing the pacth, fixing the typo and applying the patch.
Igor
On Tue, Nov 8, 2016 at 7:03 PM, Nick Clifton <nickc@redhat.com> wrote:
> Hi Igor,
>
>> * dwarf2.c (comp_unit): Add new fields 'lookup_funcinfo_table' and
>> 'number_of_functions' to keep lookup table and number of entries in
>> the table.
>> (line_sequence): Add new fields 'line_info_lookup' and 'num_lines'
>> to keep lookup table and number of entries in the table.
>> (lookup_funcinfo): New structure for lookup table for function
>> references.
>> (build_line_info_table): New function to create and build the lookup
>> table for line information.
>> (lookup_address_in_line_info_table): Use the lookup table instead of
>> traverse a linked list.
>> (compare_lookup_funcinfos): New compare fuction used in sorting of
>> lookup table for function references.
>> (build_lookup_funcinfo_table): New function to create, build and
>> sort the lookup table for functions references.
>> (lookup_address_in_function_table): Use the table instead of
>> traverse a linked list.
>> (_bfd_dwarf2_cleanup_debug_info): Free memory from function references
>> lookup table.
>
> Approved and applied - and thanks very much for creating this patch! :-)
>
> Cheers
> Nick
>