This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] bfd: Fix negative GOT offsets for non-local references on sparc64

From: jose dot marchesi at oracle dot com (Jose E. Marchesi)
To: Nick Clifton <nickc at redhat dot com>
Cc: James Clarke <jrtc27 at jrtc27 dot com>, binutils at sourceware dot org
Date: Fri, 18 Nov 2016 12:53:18 +0100
Subject: Re: [PATCH] bfd: Fix negative GOT offsets for non-local references on sparc64
Authentication-results: sourceware.org; auth=none
References: <20161114161407.4857-1-jrtc27@jrtc27.com> <87twb8ln9v.fsf@oracle.com> <9febf555-3f5d-d222-43a7-a4f624cf10ef@redhat.com>

    
    > Looks good to me.
    > 
    >     bfd/
    >      * elfxx-sparc.c (_bfd_sparc_elf_relocate_section): Don't convert
    >      R_SPARC_GOTDATA_OP_HIX22 and R_SPARC_GOTDATA_OP_LOX10 to R_SPARC_GOT*
    >      for non-local references. Instead, treat them like
    >      R_SPARC_GOTDATA_HIX22/R_SPARC_GOTDATA_LOX10 when filling in the
    >      immediate with the calculated relocation.
     
    Approved - please apply.
    
Applied to master in behalf of James Clarke.
Thanks.

References:
- [PATCH] bfd: Fix negative GOT offsets for non-local references on sparc64
  - From: James Clarke
- Re: [PATCH] bfd: Fix negative GOT offsets for non-local references on sparc64
  - From: Jose E. Marchesi
- Re: [PATCH] bfd: Fix negative GOT offsets for non-local references on sparc64
  - From: Nick Clifton

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]