This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [AArch64][4/4] Define TC_ADDRESS_BYTES for GAS


On Dez 07 2016, Yury Norov <ynorov@caviumnetworks.com> wrote:

>> This is my version of the change. The same idea, but I also set
>> bits_per_word to 32:
>> 
>> diff --git a/bfd/cpu-aarch64.c b/bfd/cpu-aarch64.c
>> index 596d241..cc98e2e 100644
>> --- a/bfd/cpu-aarch64.c
>> +++ b/bfd/cpu-aarch64.c
>> @@ -105,8 +105,13 @@ scan (const struct bfd_arch_info *info, const char *string)
>>      "aarch64", PRINT, 4, DEFAULT, compatible, scan,		\
>>      bfd_arch_default_fill, NEXT }
>>  
>> +#define N32(NUMBER, PRINT, DEFAULT, NEXT)				\
>> +  { 32, 32, 8, bfd_arch_aarch64, NUMBER,			\
>> +    "aarch64", PRINT, 4, DEFAULT, compatible, scan,		\
>> +    bfd_arch_default_fill, NEXT }
>> +
>>  static const bfd_arch_info_type bfd_aarch64_arch_ilp32 =
>> -  N (bfd_mach_aarch64_ilp32, "aarch64:ilp32", FALSE, NULL);
>> +  N32 (bfd_mach_aarch64_ilp32, "aarch64:ilp32", FALSE, NULL);

It doesn't make much sense to define another macro and use it only once.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]