This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] readelf: use hex prefix for program header alignment


On Thu, 8 Dec 2016, Étienne Buira wrote:
> ---
>  binutils/readelf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/binutils/readelf.c b/binutils/readelf.c
> index c5a628f..69d8889 100644
> --- a/binutils/readelf.c
> +++ b/binutils/readelf.c
> @@ -4900,7 +4900,7 @@ process_program_headers (FILE * file)
>  		      (segment->p_flags & PF_R ? 'R' : ' '),
>  		      (segment->p_flags & PF_W ? 'W' : ' '),
>  		      (segment->p_flags & PF_X ? 'E' : ' '));
> -	      print_vma (segment->p_align, HEX);
> +	      print_vma (segment->p_align, PREFIX_HEX);
>  	    }
>
>  	  putc ('\n', stdout);
>

Missing updates to the test-suite.  I'm guessing that's going to
be a big patch.  Also missing a changelog and it'd be nice with
some background why you want to change this now.

brgds, H-P

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]