This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH v2 1/3] Use the ELF class to determine the word size for FreeBSD core notes.
- From: Nick Clifton <nickc at redhat dot com>
- To: John Baldwin <jhb at FreeBSD dot org>, gdb-patches at sourceware dot org, binutils at sourceware dot org
- Date: Tue, 13 Dec 2016 11:04:40 +0000
- Subject: Re: [PATCH v2 1/3] Use the ELF class to determine the word size for FreeBSD core notes.
- Authentication-results: sourceware.org; auth=none
- References: <20161206210015.40422-1-jhb@FreeBSD.org> <20161206210015.40422-2-jhb@FreeBSD.org>
Hi John,
> FreeBSD MIPS64 core dumps contain an empty e_flags value so are assigned
> to the default bfd_arch_mips which is 32-bits.
I am sorry, but I am worried about this patch breaking things for other,
non-MIPS targets. Wouldn't it be easier to update bfd/elfxx-mips.c:_bfd_elf_mips_mach()
to test the EI_CLASS field if no flags are set. Maybe by using the ABI_64_P macro ?
Cheers
Nick