This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Return 'int' rather than 'unsigned short' in avrdis_opcode
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Alan Modra <amodra at gmail dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Thu, 29 Dec 2016 15:59:06 +0000
- Subject: Re: [PATCH] Return 'int' rather than 'unsigned short' in avrdis_opcode
- Authentication-results: sourceware.org; auth=none
- References: <1481536229-26099-1-git-send-email-yao.qi@linaro.org> <CAH=s-PMC3TtR1R5pdwiedhhPnJZML2NB7mtjHUFCSHhBg5ahVQ@mail.gmail.com> <20161223140219.GF2896@bubble.grove.modra.org>
On Fri, Dec 23, 2016 at 2:02 PM, Alan Modra <amodra@gmail.com> wrote:
>> > opcodes:
>> >
>> > 2016-12-12 Yao Qi <yao.qi@linaro.org>
>> >
>> > * avr-dis.c: Include "bfd_stdint.h"
>> > (avrdis_opcode): Change return type to int, add argument
>> > insn. Set *INSN on success.
>> > (print_insn_avr): Check return value of avrdis_opcode, and
>> > return -1 on error.
>
> OK.
>
Thanks for the review. Patch is pushed in.
--
Yao (齐尧)