This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: GOLD: RFA: Fixing a coverty error for aarch64.cc
- From: Cary Coutant <ccoutant at gmail dot com>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: Ian Lance Taylor <iant at google dot com>, rearnsha at arm dot com, marcus dot shawcroft at arm dot com, Binutils <binutils at sourceware dot org>
- Date: Wed, 18 Jan 2017 10:19:50 -0800
- Subject: Re: GOLD: RFA: Fixing a coverty error for aarch64.cc
- Authentication-results: sourceware.org; auth=none
- References: <87h94wmk3t.fsf@redhat.com>
> So - any objections to the patch below ? It just changes
> ST_E_835769_INSNS to be an array, like the other stubs. This may not
> be the most efficient solution, but I think that it is the simplest.
>
> gold/ChangeLog
> 2017-01-18 Nick Clifton <nickc@redhat.com>
>
> * aarch64.cc (Stub_template_repertoire): Change ST_E_835769_INSNS
> from a pointer to an array.
>
> diff --git a/gold/aarch64.cc b/gold/aarch64.cc
> index b207dcd..b282ccf 100644
> --- a/gold/aarch64.cc
> +++ b/gold/aarch64.cc
> @@ -784,8 +784,14 @@ Stub_template_repertoire<big_endian>::Stub_template_repertoire()
> 0x14000000, /* b <label> */
> };
>
> - // ST_E_835769 has the same stub template as ST_E_843419.
> - const static Insntype* ST_E_835769_INSNS = ST_E_843419_INSNS;
> + // ST_E_835769 has the same stub template as ST_E_843419
> + // but we reproduce the array here so that the sizeof
> + // expressions in install_insn_template will work.
> + const static Insntype ST_E_835769_INSNS[] =
> + {
> + 0x00000000, /* Placeholder for erratum insn. */
> + 0x14000000, /* b <label> */
> + };
>
> #define install_insn_template(T) \
> const static Stub_template<big_endian> template_##T = { \
LGTM. I can't think of a simpler fix either.
Thanks!
-cary