This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] aarch64: ld: fix relaxations for ilp32 mode


On Thu, Jan 19, 2017 at 03:47:20PM +0000, Jiong Wang wrote:
> 
> And the following coding style nits, otherwise looks good to me.
> 
> Yury Norov writes:
> 
> > +#else /*ARCH_SIZE == 32 */
> 
> /* ARCH_SIZE == 32 */
> 
> > +	  bfd_putl32 (add_R0_R0 | (TCB_SIZE << 10), contents + rel->r_offset + 4);
> 
> Over 80 columns.
> 
> > +	  bfd_putl32 (add_R0_R0 | (TCB_SIZE << 10), contents + rel->r_offset + 0);
> 
> Likewise.
> 
> -- 
> Regards,
> Jiong

Does it mean I can push it after addressing your and Andreas'
comments, or I should wait for other approves?

Yury


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]