This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] aarch64: ld: fix relaxations for ilp32 mode
- From: Nick Clifton <nickc at redhat dot com>
- To: Yury Norov <ynorov at caviumnetworks dot com>, Jiong Wang <jiong dot wang at foss dot arm dot com>
- Cc: binutils at sourceware dot org, Andreas Schwab <schwab at suse dot de>
- Date: Fri, 20 Jan 2017 12:20:22 +0000
- Subject: Re: [PATCH] aarch64: ld: fix relaxations for ilp32 mode
- Authentication-results: sourceware.org; auth=none
- References: <1484825847-30407-1-git-send-email-ynorov@caviumnetworks.com> <n99ziinniog.fsf@foss.arm.com> <20170119160814.GA501@yury-N73SV>
Hi Yuri,
> Does it mean I can push it after addressing your and Andreas'
> comments, or I should wait for other approves?
No. Please resubmit your patch with the changes suggested by the
other reviewers applied. Please also tell us how you tested the
patch, and if there were any regressions. (I really hope that
there were none...) In particular I want to be sure that you
have tested both big-endian and little-endian versions of the
aarch64 toolchain.
I would also like to know if you have run the testsuites with
-mabi=ilp32 globally enabled[1], and if that showed any problems.
Cheers
Nick
[1] You can do this in the site.exp file with an entry like this:
{ "aarch64-*" "aarch64_be-*" } {
set target_list "aarch64-sim{-mabi=ilp32}"
set ASFLAGS "-mabi=ilp32"
}