This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 5/5] PR ld/20828: Reorder the symbol sweep stage of section GC
- From: Alan Modra <amodra at gmail dot com>
- To: "Maciej W. Rozycki" <macro at imgtec dot com>
- Cc: Nick Clifton <nickc at redhat dot com>, Tristan Gingold <gingold at adacore dot com>, James Cowgill <James dot Cowgill at imgtec dot com>, "Maciej W. Rozycki" <macro at linux-mips dot org>, binutils at sourceware dot org
- Date: Tue, 24 Jan 2017 11:48:15 +1030
- Subject: Re: [PATCH 5/5] PR ld/20828: Reorder the symbol sweep stage of section GC
- Authentication-results: sourceware.org; auth=none
- References: <bug-20828-70@http.sourceware.org/bugzilla/> <bug-20828-70-QMcZ2LkAaY@http.sourceware.org/bugzilla/> <e6ca2026-eead-8e4a-b99b-dba27c41ac0d@redhat.com> <alpine.DEB.2.00.1701191811170.6936@tp.orcam.me.uk> <alpine.DEB.2.00.1701202112480.6936@tp.orcam.me.uk> <alpine.DEB.2.00.1701211939040.13564@tp.orcam.me.uk>
On Mon, Jan 23, 2017 at 11:38:20AM +0000, Maciej W. Rozycki wrote:
> PR ld/20828
> * elflink.c (bfd_elf_record_link_assignment): Revert last
> change and don't ever clear `forced_local'. Set `mark'
> unconditionally.
> (elf_gc_sweep_symbol_info, elf_gc_sweep_symbol): Reorder within
> file.
> (elf_gc_sweep): Move the call to `elf_gc_sweep_symbol'...
> (bfd_elf_size_dynamic_sections): ... here.
> * elf32-ppc.c (ppc_elf_tls_setup): Don't clear `forced_local'
> and set `mark' instead in `__tls_get_addr_opt' processing.
> * elf64-ppc.c (ppc64_elf_tls_setup): Likewise.
I think this is OK for master, but please delay putting this patch on
the branch for a while. There is a possibility that the change might
tickle bugs in some target check_relocs.
--
Alan Modra
Australia Development Lab, IBM