This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Fix PR 20995 for cris-linux (please have a look)
On Fri, Jan 27, 2017 at 07:23:42PM +0100, Hans-Peter Nilsson wrote:
> I had to look up what that was about. In all fairness, the
> "weirdness" is copied over from the also unconverted
> elf32-m68k.c (see top of elf32-cris.c) long before any
> hash-table-shortcuts, and the quoted lines have since been
> touched only by you and Nick. At least, so says git. Almost
> identical to other targets, in particular the .got-weirdness.
You're right, elf32-cris.c isn't so weird when you look into it. I
could have converted over elf32-cris.c to use the shortcuts without
too much thought, but at the time it seemed safer to leave it to the
maintainer.
> Yes, it seems wrong to match (all) sections with ".got" as a
> prefix, as opposed to specifically ".got" and ".got.plt". Maybe
> a misguided attempt at future-proofness and/or slipping into
> using the same pattern needed for ".rela"-sections (still, maybe
> name-matching isn't needed there either).
You'll still need the name matching for .rela sections (but not for
.rela.got and .rela.plt).
--
Alan Modra
Australia Development Lab, IBM