This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[committed] LD/testsuite: ld-lib.exp: Fix a typo, s/regexp/regex/


Match `$check_ld(source)' against "regex" rather than "regexp" in 
reporting, correcting test framework diagnostics, e.g.:

tmpdir/undefined.o: In function `foo':
(.text+0x0): undefined reference to `bar'
failed with: <tmpdir/undefined.o: In function `foo':
(.text+0x0): undefined reference to `bar'>, no expected output
tmpdir/undefined.o: In function `foo':
(.text+0x0): undefined reference to `bar'
PASS: MIPS undefined reference

(current) vs:

tmpdir/undefined.o: In function `foo':
(.text+0x0): undefined reference to `bar'
failed with: <tmpdir/undefined.o: In function `foo':
(.text+0x0): undefined reference to `bar'>, expected: <\A[^\n]*\.o: In function `foo':\n\(\.text\+0x0\): undefined reference to `bar'\Z>
tmpdir/undefined.o: In function `foo':
(.text+0x0): undefined reference to `bar'
PASS: MIPS undefined reference

(corrected).  No functional change.

	ld/
	* ld/testsuite/lib/ld-lib.exp (run_dump_test): Fix a typo, 
	s/regexp/regex/.
---
 Committed as obvious.

  Maciej

binutils-ld-test-run-dump-regex.diff
Index: binutils/ld/testsuite/lib/ld-lib.exp
===================================================================
--- binutils.orig/ld/testsuite/lib/ld-lib.exp	2017-01-17 22:26:06.744840922 +0000
+++ binutils/ld/testsuite/lib/ld-lib.exp	2017-01-17 22:29:48.073146837 +0000
@@ -956,7 +956,7 @@ proc run_dump_test { name {extra_options
 	    set exitstat "succeeded"
 	    if { $cmdret != 0 } { set exitstat "failed" }
 
-            if { $check_ld(source) == "regexp" } {
+            if { $check_ld(source) == "regex" } {
                 verbose -log "$exitstat with: <$comp_output>, expected: <$check_ld(regex)>"
             } elseif { $check_ld(source) == "file" } {
                 verbose -log "$exitstat with: <$comp_output>, expected in file $check_ld(file)"


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]