This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[GOLD] PowerPC64 TOC indirect to TOC relative segfault
- From: Alan Modra <amodra at gmail dot com>
- To: binutils at sourceware dot org
- Date: Fri, 3 Feb 2017 20:05:01 +1030
- Subject: [GOLD] PowerPC64 TOC indirect to TOC relative segfault
- Authentication-results: sourceware.org; auth=none
Newer versions of gcc don't create an empty .toc section.
* powerpc.cc (Powerpc_relobj::make_toc_relative): Don't crash
when no .toc section exists.
diff --git a/gold/powerpc.cc b/gold/powerpc.cc
index a67c336..4abfcec 100644
--- a/gold/powerpc.cc
+++ b/gold/powerpc.cc
@@ -1986,6 +1986,12 @@ Powerpc_relobj<size, big_endian>::make_toc_relative(
if (size != 64)
return false;
+ // With -mcmodel=medium code it is quite possible to have
+ // toc-relative relocs referring to objects outside the TOC.
+ // Don't try to look at a non-existent TOC.
+ if (this->toc_shndx() == 0)
+ return false;
+
// Convert VALUE back to an address by adding got_base (see below),
// then to an offset in the TOC by subtracting the TOC output
// section address and the TOC output offset. Since this TOC output
--
Alan Modra
Australia Development Lab, IBM