This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [ld, testsuite] Relax the expectation pattern for several plugin-* tests
- From: Alan Modra <amodra at gmail dot com>
- To: Jiong Wang <jiong dot wang at foss dot arm dot com>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, Binutils <binutils at sourceware dot org>
- Date: Thu, 16 Feb 2017 10:12:29 +1030
- Subject: Re: [ld, testsuite] Relax the expectation pattern for several plugin-* tests
- Authentication-results: sourceware.org; auth=none
- References: <20150205135440.GA27203@gmail.com> <20150207094240.GD14796@bubble.grove.modra.org> <CAMe9rOoC1KKOHtPT81fFAnU8sjHWO0BLjG2=XoGU=b1oiuR10g@mail.gmail.com> <CAMe9rOo_u9VL2KjczbppH7C8Kv-j6-EOvPrB12Vw65Ro_mg4+g@mail.gmail.com> <54E61565.2090008@arm.com> <CAMe9rOr+xobuKsKDK1fHJXZ0qCtVSjy6=jzFbiXBuceLwvu1YQ@mail.gmail.com> <CAMe9rOpsjqOKz4pi9k8sCn_ESUeEnFE0zF5EsF9-74TQ4h+zRA@mail.gmail.com> <355e66f1-d3f6-25e6-1f07-d60fdc7122cf@foss.arm.com> <CAMe9rOqfBhyGq_ea-vhUWUgvc2F+b=Gh2TjPwXDeu1bAk=PR5g@mail.gmail.com> <8e8ac1ef-5410-9251-f6dd-7dc960b65967@foss.arm.com>
On Wed, Feb 15, 2017 at 05:46:46PM +0000, Jiong Wang wrote:
> On 13/02/17 16:57, H.J. Lu wrote:
> >I agree that ARM linker shouldn't complain IR symbols in this case.
> >Can you update ARM linker like this?
>
> Hmm, I saw BFD_PLUGIN is set together with BFD_LINKER_CREATED, so the current
> check in INTERWORK_FLAG should have covered this. While it is not, so I guess
> in some place bfd linker dropped the BFD_LINKER_CREATED bit.
>
> Some search in the code, it looks to me we should also save "BFD_LINKER_CREATED"
> in BFD_FLAGS_SAVED in bfd.c/bfd-in2.h? I have made this change locally, and
> these failures gone away on arm native ld check without regression.
A patch to add that to BFD_FLAGS_SAVED in bfd.c is preapproved.
--
Alan Modra
Australia Development Lab, IBM