This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
PR21132, hppa-linux pie support doesn't work
- From: Alan Modra <amodra at gmail dot com>
- To: binutils at sourceware dot org
- Date: Thu, 16 Feb 2017 22:55:35 +1030
- Subject: PR21132, hppa-linux pie support doesn't work
- Authentication-results: sourceware.org; auth=none
This fixes a long-standing hppa bug seen when generating PIEs, and I
think possible to trigger with forced local symbols in shared
libraries. Not allocating enough space for PLT relocs results in ld
writing outside of the buffer.
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index a6a4c64..4be12b8 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2017-02-16 Alan Modra <amodra@gmail.com>
+
+ PR 21132
+ * elf32-hppa.c (allocate_plt_static): Allocate space for relocs
+ if pic.
+
2017-02-16 Jiong Wang <jiong.wang@arm.com>
* bfd.c (BFD_FLAGS_SAVED): Add BFD_LINKER_CREATED.
diff --git a/bfd/elf32-hppa.c b/bfd/elf32-hppa.c
index de14468..e64ea9a 100644
--- a/bfd/elf32-hppa.c
+++ b/bfd/elf32-hppa.c
@@ -1976,6 +1976,8 @@ allocate_plt_static (struct elf_link_hash_entry *eh, void *inf)
sec = htab->etab.splt;
eh->plt.offset = sec->size;
sec->size += PLT_ENTRY_SIZE;
+ if (bfd_link_pic (info))
+ htab->etab.srelplt->size += sizeof (Elf32_External_Rela);
}
else
{
--
Alan Modra
Australia Development Lab, IBM