This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Add documentation of warning if byte size exceeded
- From: Nick Clifton <nickclifton at nickclifton dot clara dot co dot uk>
- To: "Tobin C. Harding" <me at tobin dot cc>
- Cc: Alan Modra <amodra at gmail dot com>, binutils at sourceware dot org
- Date: Fri, 10 Mar 2017 15:41:57 +0000
- Subject: Re: [PATCH] Add documentation of warning if byte size exceeded
- Authentication-results: sourceware.org; auth=none
- References: <1488878554-19889-1-git-send-email-me@tobin.cc> <20170307094203.GB21536@eros>
Hi Tobin,
>> GAS throws a warning if an attempt is made to declare data that
>> exceeds the size allocated when using directives .2byte or .4byte.
I have taken your patch and extended it slightly in order to tidy up
the wording. Attached is the patch that I have committed.
>> I see that the patch prior to this one (commit d10ef45) has caused
>> build fail for someone.
I did not see this. The documentation builds fine for me. Are you sure
that it is still a problem ?
Cheers
Nick
gas/ChangeLog
2017-03-10 Tobin C. Harding <me@tobin.cc>
Nick Clifton <nickc@redhat.com>
* doc/as.texinfo (2byte): Tidy up wording. Add note that
overlarge values will produce a warning message and be trunacted.
(4byte): Likewise.
diff --git a/gas/doc/as.texinfo b/gas/doc/as.texinfo
index a8f014b..3b3e931 100644
--- a/gas/doc/as.texinfo
+++ b/gas/doc/as.texinfo
@@ -7345,9 +7345,11 @@ instead of zero. Using @samp{.zero} in this way would be confusing however.
@cindex two-byte integer
@cindex integer, 2-byte
-This directive @code{.2byte}, which is available for ELF targets, expects zero
-or more expressions, separated by commas. Each expression is assembled into the
-next two bytes.
+This directive expects zero or more expressions, separated by commas. Each
+expression is evaluated and placed in the next two bytes of the current
+section. If an expression will not fit in two bytes, a warning message
+is displayed and the lowest two bytes of the expression's value are used.
+This directive is only available for ELF targets,
@node 4byte
@section @code{.4byte @var{expression} [, @var{expression}]*}
@@ -7355,9 +7357,11 @@ next two bytes.
@cindex four-byte integer
@cindex integer, 4-byte
-This directive @code{.4byte}, which is available for ELF targets, expects zero
-or more expressions, separated by commas. Each expression is assembled into the
-next four bytes.
+This directive expects zero or more expressions, separated by commas. Each
+expression is evaluated and placed in the next four bytes of the current
+section. If an expression will not fit in four bytes, a warning message
+is displayed and the lowest four bytes of the expression's value are used.
+This directive is only available for ELF targets,
@node 8byte
@section @code{.8byte @var{expression} [, @var{expression}]*}
@@ -7365,10 +7369,11 @@ next four bytes.
@cindex eight-byte integer
@cindex integer, 8-byte
-This directive @code{.8byte}, which is available for ELF targets, expects zero
-or more bignums, separated by commas. For each bignum, it emits
-an 8-byte integer. If the bignum won't fit in 8 bytes, it prints a
-warning message; and just takes the lowest order 8 bytes of the bignum.
+This directive expects zero or more expressions, separated by commas. Each
+expression is evaluated and the resulting bignum is placed in the next eight
+bytes of the current section. If an expression will not fit in eight bytes, a
+warning message is displayed and the lowest eight bytes of the expression's
+value are used. This directive is only available for ELF targets,
@end ifset
@node Deprecated