This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[committed, PATCH] x86-64: Use "=" instead of "+=" to update 0


Use

  if (htab->elf.splt->size == 0)
    htab->elf.splt->size = GET_PLT_ENTRY_SIZE (output_bfd);

instead of

  if (htab->elf.splt->size == 0)
    htab->elf.splt->size += GET_PLT_ENTRY_SIZE (output_bfd);

	* elf64-x86-64.c (elf_x86_64_size_dynamic_sections): Use "="
	instead of "+=" to update 0.
---
 bfd/ChangeLog      | 5 +++++
 bfd/elf64-x86-64.c | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 0d328b4..3ae5c9f 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,5 +1,10 @@
 2017-04-27  H.J. Lu  <hongjiu.lu@intel.com>
 
+	* elf64-x86-64.c (elf_x86_64_size_dynamic_sections): Use "="
+	instead of "+=" to update 0.
+
+2017-04-27  H.J. Lu  <hongjiu.lu@intel.com>
+
 	* elf32-i386.c (elf_i386_create_dynamic_sections): Create the
 	.plt.got section here.
 	(elf_i386_check_relocs): Don't create the .plt.got section.
diff --git a/bfd/elf64-x86-64.c b/bfd/elf64-x86-64.c
index 5985319..6f9bc36 100644
--- a/bfd/elf64-x86-64.c
+++ b/bfd/elf64-x86-64.c
@@ -3850,7 +3850,7 @@ elf_x86_64_size_dynamic_sections (bfd *output_bfd,
 	  /* Reserve room for the initial entry.
 	     FIXME: we could probably do away with it in this case.  */
 	  if (htab->elf.splt->size == 0)
-	    htab->elf.splt->size += GET_PLT_ENTRY_SIZE (output_bfd);
+	    htab->elf.splt->size = GET_PLT_ENTRY_SIZE (output_bfd);
 	  htab->tlsdesc_plt = htab->elf.splt->size;
 	  htab->elf.splt->size += GET_PLT_ENTRY_SIZE (output_bfd);
 	}
-- 
2.9.3


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]