This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH, LD, ping] Make import libraries relocatable objects
- From: Nick Clifton <nickc at redhat dot com>
- To: Thomas Preudhomme <thomas dot preudhomme at foss dot arm dot com>, Richard Earnshaw <richard dot earnshaw at arm dot com>, Alan Modra <amodra at gmail dot com>, binutils at sourceware dot org
- Date: Fri, 5 May 2017 10:14:09 +0100
- Subject: Re: [PATCH, LD, ping] Make import libraries relocatable objects
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=nickc at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 93D3B8553D
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 93D3B8553D
- References: <3f56df33-a8ee-778d-a1b8-7a91c68cc359@foss.arm.com> <df35d39c-b6d5-eae3-dcad-3456cedbda74@foss.arm.com>
Hi Thomas,
> Ping?
Oops - sorry - I was assuming that one of the ARM maintainers would look at this.
>> *** bfd/ChangeLog ***
>>
>> 2017-04-25 Thomas Preud'homme <thomas.preudhomme@arm.com>
>>
>> * elflink.c (elf_output_implib): Remove executable flag from import
>> library bfd.
>> * elf32-arm.c (elf32_arm_filter_implib_symbols): Assert that the import
>> library is a relocatable object file.
>>
>> *** ld/ChangeLog ***
>>
>> 2017-04-25 Thomas Preud'homme <thomas.preudhomme@arm.com>
>>
>> * testsuite/ld-arm/arm-elf.exp
>> (Secure gateway import library generation): Check e_type field
>> of import library and executable produced.
>> * testsuite/ld-arm/cmse-implib.type: Expectations for e_type field.
>>
>> Testing: testsuite shows no regression when run for arm-none-eabi and
>> armeb-none-eabi.
>>
>> Is this ok for master?
Approved - please apply, but, please could you make one small change:
+ BFD_ASSERT (!(bfd_get_file_flags (info->out_implib_bfd) & EXEC_P));
Please could you add a comment above this assert referencing the ARM ECM
document and explaining why the check is here ?
Cheers
Nick