This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH V2 2/3] bfd: fix the deletion of relocs in sparc64

From: jose dot marchesi at oracle dot com (Jose E. Marchesi)
To: binutils at sourceware dot org
Date: Wed, 10 May 2017 18:50:56 +0200
Subject: Re: [PATCH V2 2/3] bfd: fix the deletion of relocs in sparc64
Authentication-results: sourceware.org; auth=none
References: <1493986217-9037-1-git-send-email-jose.marchesi@oracle.com> <1493986217-9037-3-git-send-email-jose.marchesi@oracle.com>

    This patch fixes the deletion of relocations in BFD sections in
    sparc64 targets.
    
    A specialized `_bfd_set_reloc' function is provided that updates the
    internal canon_reloc_count(sec) counter instead of sec->reloc_count.
    Additionally, the `write_relocs' callback in elf64-sparc is adapted to
    use the canon_reloc_count to traverse `sec->orelocation'.
    
    Tested in sparc64-linux-gnu targets.
    Fixes an existing failure in the merge-notes objcopy test.
    No regressions.
    
    bfd/ChangeLog:
    
    2017-05-05  Jose E. Marchesi  <jose.marchesi@oracle.com>
    
    	* elf64-sparc.c (elf64_sparc_set_reloc): New function.
    	(bfd_elf64_set_reloc): Define.
    	(elf64_sparc_write_relocs): Use `canon_reloc_count'.


I just applied this patch.

References:
- [PATCH V2 0/3] Fix relocation deletion problems in SPARC and MIPS
  - From: Jose E. Marchesi
- [PATCH V2 2/3] bfd: fix the deletion of relocs in sparc64
  - From: Jose E. Marchesi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]