This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] X86: Add SHL/SAL ModRM.reg == 6 alias
- From: "Jan Beulich" <JBeulich at suse dot com>
- To: "Borislav Petkov" <bp at suse dot de>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>,<binutils at sourceware dot org>, "Michael Matz" <matz at suse dot de>
- Date: Tue, 23 May 2017 07:45:19 -0600
- Subject: Re: [PATCH] X86: Add SHL/SAL ModRM.reg == 6 alias
- Authentication-results: sourceware.org; auth=none
- References: <20170523131315.GH25315@nazgul.tnic>
>>> On 23.05.17 at 15:13, <bp@suse.de> wrote:
> --- a/opcodes/i386-dis.c
> +++ b/opcodes/i386-dis.c
> @@ -3482,7 +3482,7 @@ static const struct dis386 reg_table[][8] = {
> { "rcrA", { Eb, I1 }, 0 },
> { "shlA", { Eb, I1 }, 0 },
> { "shrA", { Eb, I1 }, 0 },
> - { Bad_Opcode },
> + { "shlA", { Eb, I1 }, 0 },
> { "sarA", { Eb, I1 }, 0 },
> },
I can certainly see why we want this (and I think I even have a
similar change sitting somewhere waiting to be submitted), but ...
> --- a/opcodes/i386-opc.tbl
> +++ b/opcodes/i386-opc.tbl
... why does the assembler need to know? When we've added
support for other aliases not so long ago, we did leave the
assembler alone.
I've also added H.J. as the x86 maintainer to Cc.
Jan