This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] ELF/BFD: Hold the number of internal static relocs in `->reloc_count'

From: Alan Modra <amodra at gmail dot com>
To: "Maciej W. Rozycki" <macro at imgtec dot com>
Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, "Jose E. Marchesi" <jose dot marchesi at oracle dot com>, binutils at sourceware dot org
Date: Fri, 2 Jun 2017 10:55:41 +0930
Subject: Re: [PATCH] ELF/BFD: Hold the number of internal static relocs in `->reloc_count'
Authentication-results: sourceware.org; auth=none
References: <alpine.DEB.2.00.1705301242420.2590@tp.orcam.me.uk> <20170602000254.GP8842@bubble.grove.modra.org> <alpine.DEB.2.00.1706020108010.2590@tp.orcam.me.uk>

On Fri, Jun 02, 2017 at 01:23:40AM +0100, Maciej W. Rozycki wrote:
>  I'll go with:
> 
>       size = o->reloc_count;
>       size *= sizeof (Elf_Internal_Rela);
> 
> then if you don't mind.  I find explicit casts worsen code readability.

Fine by me.

-- 
Alan Modra
Australia Development Lab, IBM

References:
- [PATCH] ELF/BFD: Hold the number of internal static relocs in `->reloc_count'
  - From: Maciej W. Rozycki
- Re: [PATCH] ELF/BFD: Hold the number of internal static relocs in `->reloc_count'
  - From: Alan Modra
- Re: [PATCH] ELF/BFD: Hold the number of internal static relocs in `->reloc_count'
  - From: Maciej W. Rozycki

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]