This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Don't look up a stub for an undefined symbol.
- From: Eric Christopher <echristo at gmail dot com>
- To: Cary Coutant <ccoutant at gmail dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, Han Shen <shenhan at google dot com>
- Date: Wed, 7 Jun 2017 17:56:32 -0700
- Subject: Re: [PATCH] Don't look up a stub for an undefined symbol.
- Authentication-results: sourceware.org; auth=none
- References: <CALehDX5Gt2DuvdjkQB+u_9bP43_YCbnBM5NxHZ_Y=pH_FutmkQ@mail.gmail.com> <CAJimCsHx6WUn=FngjkZ1AxCpd03+UwpiRkfu35K9rpC_VH=ykA@mail.gmail.com>
On Wed, Jun 7, 2017 at 5:36 PM, Cary Coutant <ccoutant@gmail.com> wrote:
>> 2017-06-07 Eric Christopher <echristo@gmail.com>
>>
>> * aarch64.cc (maybe_apply_stub): Add debug logging for looking
>> up stubs to undefined symbols and early return rather than
>> fail to look them up.
>> (scan_reloc_for_stub): Add debug logging for no stub creation
>> for undefined symbols.
>
> + // We don't create stubs for undefined symbols so don't look for one.
> + if (gsym && gsym->is_undefined()) {
> + gold_debug(DEBUG_TARGET,
> + "stub: looking for a stub for undefined symbol: %s",
> + gsym->name());
> + return false;
> + }
>
> The braces here aren't Gnu style. Fix that, and it's OK to apply. Thanks!
>
Oops, thanks :)
Pushed thusly:
echristo@athyra ~/s/binutils-gdb> git push origin master
To ssh://sourceware.org/git/binutils-gdb.git
3030551ec5..81b6fe3bf9 master -> master
-eric