This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Rewrite __start and __stop symbol handling

On Fri, Jun 16, 2017 at 11:29:00PM -0400, Hans-Peter Nilsson wrote:
> On Fri, 16 Jun 2017, Alan Modra wrote:
> > This arranges for __start and __stop symbols to be defined before
> > garbage collection, for all target formats.
> 
> > ld/
> 
> > 	* testsuite/ld-elf/pr21562a.d: Use xfail rather than notarget.
> > 	Correct typos and list of xfail targets.
> 
> The list of targets looks improved (thanks ;) but the use of
> notarget was correct before from the looks of it: the test
> wasn't made to work for them as opposed to there being a bug.
> Unless I miss something (in which case the comment could be
> updated to something more verbose)?

You're correct, but I prefer to use xfail in cases where a test fails
due to missing target support, eg. --gc-sections, that may be added in
future.  I was also going to modify the tests to support targets that
add leading underscores to C identifiers, but hadn't gotten around to
it.

-- 
Alan Modra
Australia Development Lab, IBM
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]