This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 1/2] [ARC] Fix handling of cpu=... disassembler option value

On 6/20/17 5:32 AM, Pedro Alves wrote:
> - I'm not sure on coding standard on the bfd side, but on the gdb side
>   you'd write "disassembler_options_cmp (...) == 0" instead of 
>   !disassembler_options_cmp, since the return value isn't a boolean.

It's the same on bfd side too, so "... == 0" is preferred.



> Both ARM and Power test these FOR_EACH_DISASSEMBLER_OPTION-related paths
> using GDB's testsuite.  Grep for "set disassembler-options" under
> gdb/testsuite/gdb.arch/.  But IIUC, ARC doesn't support
> "set disassembler-options" yet, right?

When I added the "set disassembler-options ..." support, I included
support for it in PPC, ARM and S390.  ARC doesn't support it, but from
a quick glance, it also doesn't look too hard to add.

Peter
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]