This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] RISC-V: Error, don't warn, for shfit amounts/CSRs


On Fri, 23 Jun 2017 02:32:27 PDT (-0700), Nick Clifton wrote:
> Hi Palmer,
>
>> 2017-05-11  Andrew Waterman  <andrew@sifive.com>
>>
>>         * config/tc-riscv.c (riscv_ip): Changes as_warn to as_bad for improper
>>         shift amounts.
>
> Approved - please apply.

Committed.

> But ...
>
>> diff --git a/gas/ChangeLog b/gas/ChangeLog
>> index 93914da731..e5130e73cc 100644
>> --- a/gas/ChangeLog
>> +++ b/gas/ChangeLog
>> @@ -1,3 +1,8 @@
>> +2017-05-11  Andrew Waterman  <andrew@sifive.com>
>> +
>> +	* config/tc-riscv.c (riscv_ip): Changes as_warn to as_bad for improper
>> +	shift amounts.
>> +
>>   2017-06-22  Nick Clifton  <nickc@redhat.com>
>>
>>   	* config/tc-arm.c (arm_ext_v7m): Add ATTRIBUTE_UNUSED.
>
> Please could you include ChangeLog entries as just plain text.  They
> almost never apply cleanly as context diffs because the changelogs
> are being updated so frequently.

I've been using git-merge-changelog (which someone suggested on this list) to
track these and haven't had any merge problems, but if this causes trouble then
I can stop doing that.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]