This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] X86: Disassemble primary opcode map's group 2 ModRM.reg == 6 aliases correctly
- From: "Jan Beulich" <JBeulich at suse dot com>
- To: "Borislav Petkov" <bp at suse dot de>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, "Binutils" <binutils at sourceware dot org>,"Michael Matz" <matz at suse dot de>
- Date: Wed, 05 Jul 2017 03:29:13 -0600
- Subject: Re: [PATCH] X86: Disassemble primary opcode map's group 2 ModRM.reg == 6 aliases correctly
- Authentication-results: sourceware.org; auth=none
- References: <CAMe9rOpzaPjtoQAiYa9Qwj7kfxnZRRtab9=b746vD75o546s0g@mail.gmail.com> <CAMe9rOpv9b3XtYLnoQKYiaDZ1rKNpsn=Sa0cQ+3j=MsXU_R-7Q@mail.gmail.com> <592DA5C7020000780015DBE6@prv-mh.provo.novell.com> <CAMe9rOr6gFmPFgnJVaxXZP+xTH6go1fhtxS2rQPP0h4nrpc9dA@mail.gmail.com> <20170530151029.w2xofh2nlsa7vu64@pd.tnic> <CAMe9rOqOTWTpXkB-UvON_9ik1xYcLQv6GVmeNvzSX-eagtcGvw@mail.gmail.com> <20170530151711.mox3pdnvnmrytelu@pd.tnic> <CAMe9rOpurDgPD9owq67PeTJhJuRRqn7CJh8EyOPTkQSyqsQHpQ@mail.gmail.com> <20170530154837.ywwlydygjxe4sf3g@pd.tnic> <CAMe9rOrJv3M6F01jAn0zy826t8=cBnZy00GBdNi1azpBMFsgZg@mail.gmail.com> <20170705090538.GA26150@nazgul.tnic>
>>> On 05.07.17 at 11:05, <bp@suse.de> wrote:
> On Tue, May 30, 2017 at 09:23:25AM -0700, H.J. Lu wrote:
>> On Tue, May 30, 2017 at 8:48 AM, Borislav Petkov <bp@suse.de> wrote:
>> > On Tue, May 30, 2017 at 08:19:49AM -0700, H.J. Lu wrote:
>> >> There is no SAL, which is just an alias of SHL in assembler.
>> >
>> > Well, the only thing that matters is that he hardware accepts a /6.
>> >
>> > If I had to guess, though, it probably turns it into the /4 variant by
>> > masking out the second bit of the .reg field...
>> >
>> > Anyway, here's the previous version with shl from a couple mails ago
>> > upthread:
>>
>> This is OK.
>
> Jan, Micha, can one of you guys check this in now pls?
Done.
Jan