This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Move print_insn_XXX to an opcodes internal header, again
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Alan Modra <amodra at gmail dot com>
- Cc: binutils at sourceware dot org
- Date: Mon, 10 Jul 2017 17:14:58 +0100
- Subject: Re: Move print_insn_XXX to an opcodes internal header, again
- Authentication-results: sourceware.org; auth=none
- References: <20170707025510.GI14520@bubble.grove.modra.org>
Alan Modra <amodra@gmail.com> writes:
> 88c1242dc0a changed some generated files rather than the source.
>
> * cgen-dis.in: Include disassemble.h, not dis-asm.h.
> * m32c-dis.c: Regenerate.
> * mep-dis.c: Regenerate.
I didn't realize that these files are generated. When I modified them,
I didn't read the the comments on the top of the file. How about
marking them read-only? so that people who change them will immediately
realize that they are generated by other files. How is the patch below?
--
Yao (齐尧)
From eed5f2ea72c90d04a2a5ea1b8b4b4bedcb5ae729 Mon Sep 17 00:00:00 2001
From: Yao Qi <yao.qi@linaro.org>
Date: Mon, 10 Jul 2017 17:07:04 +0100
Subject: [PATCH] [opcodes] Mark generated .c files read-only
opcodes:
2017-07-10 Yao Qi <yao.qi@linaro.org>
* cgen.sh: Insert a line of comment to mark generated c files
read-only.
* epiphany-dis.c: Regenerate.
* fr30-dis.c: Regenerate.
* frv-dis.c: Regenerate.
* ip2k-dis.c: Regenerate.
* iq2000-dis.c: Regenerate.
* lm32-dis.c: Regenerate.
* m32c-dis.c: Regenerate.
* m32r-dis.c: Regenerate.
* mep-dis.c: Regenerate.
* mt-dis.c: Regenerate.
* or1k-dis.c: Regenerate.
* xc16x-dis.c: Regenerate.
* xstormy16-dis.c Regenerate.
diff --git a/opcodes/cgen.sh b/opcodes/cgen.sh
index 637cf89..cdfa011 100644
--- a/opcodes/cgen.sh
+++ b/opcodes/cgen.sh
@@ -155,6 +155,8 @@ opcodes)
| sed -e "s/@ARCH@/${ARCH}/g" -e "s/@arch@/${arch}/g" \
-e "s/@prefix@/${prefix}/" -e 's/[ ][ ]*$//' \
> ${tmp}-dis.c
+ # Mark these generated files read-only.
+ sed -i '1 i /* -*- buffer-read-only: t -*- vi:set ro: *\/' ${tmp}-dis.c
${rootdir}/move-if-change ${tmp}-dis.c ${srcdir}/${prefix}-dis.c
# Remove temporary files.
diff --git a/opcodes/epiphany-dis.c b/opcodes/epiphany-dis.c
index 90458dd..4629549 100644
--- a/opcodes/epiphany-dis.c
+++ b/opcodes/epiphany-dis.c
@@ -1,3 +1,4 @@
+/* -*- buffer-read-only: t -*- vi:set ro: */
/* Disassembler interface for targets using CGEN. -*- C -*-
CGEN: Cpu tools GENerator
diff --git a/opcodes/fr30-dis.c b/opcodes/fr30-dis.c
index 70ad479..b3f8530 100644
--- a/opcodes/fr30-dis.c
+++ b/opcodes/fr30-dis.c
@@ -1,3 +1,4 @@
+/* -*- buffer-read-only: t -*- vi:set ro: */
/* Disassembler interface for targets using CGEN. -*- C -*-
CGEN: Cpu tools GENerator
diff --git a/opcodes/frv-dis.c b/opcodes/frv-dis.c
index 60b8f3f..ab5eb51 100644
--- a/opcodes/frv-dis.c
+++ b/opcodes/frv-dis.c
@@ -1,3 +1,4 @@
+/* -*- buffer-read-only: t -*- vi:set ro: */
/* Disassembler interface for targets using CGEN. -*- C -*-
CGEN: Cpu tools GENerator
diff --git a/opcodes/ip2k-dis.c b/opcodes/ip2k-dis.c
index e6008bd..4d095a2 100644
--- a/opcodes/ip2k-dis.c
+++ b/opcodes/ip2k-dis.c
@@ -1,3 +1,4 @@
+/* -*- buffer-read-only: t -*- vi:set ro: */
/* Disassembler interface for targets using CGEN. -*- C -*-
CGEN: Cpu tools GENerator
diff --git a/opcodes/iq2000-dis.c b/opcodes/iq2000-dis.c
index 1d55187..f75a225 100644
--- a/opcodes/iq2000-dis.c
+++ b/opcodes/iq2000-dis.c
@@ -1,3 +1,4 @@
+/* -*- buffer-read-only: t -*- vi:set ro: */
/* Disassembler interface for targets using CGEN. -*- C -*-
CGEN: Cpu tools GENerator
diff --git a/opcodes/lm32-dis.c b/opcodes/lm32-dis.c
index 8238993..b18b7a2 100644
--- a/opcodes/lm32-dis.c
+++ b/opcodes/lm32-dis.c
@@ -1,3 +1,4 @@
+/* -*- buffer-read-only: t -*- vi:set ro: */
/* Disassembler interface for targets using CGEN. -*- C -*-
CGEN: Cpu tools GENerator
diff --git a/opcodes/m32c-dis.c b/opcodes/m32c-dis.c
index e4fc6f6..03e1bba 100644
--- a/opcodes/m32c-dis.c
+++ b/opcodes/m32c-dis.c
@@ -1,3 +1,4 @@
+/* -*- buffer-read-only: t -*- vi:set ro: */
/* Disassembler interface for targets using CGEN. -*- C -*-
CGEN: Cpu tools GENerator
diff --git a/opcodes/m32r-dis.c b/opcodes/m32r-dis.c
index bee98bd..809f118 100644
--- a/opcodes/m32r-dis.c
+++ b/opcodes/m32r-dis.c
@@ -1,3 +1,4 @@
+/* -*- buffer-read-only: t -*- vi:set ro: */
/* Disassembler interface for targets using CGEN. -*- C -*-
CGEN: Cpu tools GENerator
diff --git a/opcodes/mep-dis.c b/opcodes/mep-dis.c
index a8888d9..75de781 100644
--- a/opcodes/mep-dis.c
+++ b/opcodes/mep-dis.c
@@ -1,3 +1,4 @@
+/* -*- buffer-read-only: t -*- vi:set ro: */
/* Disassembler interface for targets using CGEN. -*- C -*-
CGEN: Cpu tools GENerator
diff --git a/opcodes/mt-dis.c b/opcodes/mt-dis.c
index fddbc81..88d434c 100644
--- a/opcodes/mt-dis.c
+++ b/opcodes/mt-dis.c
@@ -1,3 +1,4 @@
+/* -*- buffer-read-only: t -*- vi:set ro: */
/* Disassembler interface for targets using CGEN. -*- C -*-
CGEN: Cpu tools GENerator
diff --git a/opcodes/or1k-dis.c b/opcodes/or1k-dis.c
index c9a7620..3c3915e 100644
--- a/opcodes/or1k-dis.c
+++ b/opcodes/or1k-dis.c
@@ -1,3 +1,4 @@
+/* -*- buffer-read-only: t -*- vi:set ro: */
/* Disassembler interface for targets using CGEN. -*- C -*-
CGEN: Cpu tools GENerator
diff --git a/opcodes/xc16x-dis.c b/opcodes/xc16x-dis.c
index 1cbf119..a3a101e 100644
--- a/opcodes/xc16x-dis.c
+++ b/opcodes/xc16x-dis.c
@@ -1,3 +1,4 @@
+/* -*- buffer-read-only: t -*- vi:set ro: */
/* Disassembler interface for targets using CGEN. -*- C -*-
CGEN: Cpu tools GENerator
diff --git a/opcodes/xstormy16-dis.c b/opcodes/xstormy16-dis.c
index 0b7fdf3..93f3ce2 100644
--- a/opcodes/xstormy16-dis.c
+++ b/opcodes/xstormy16-dis.c
@@ -1,3 +1,4 @@
+/* -*- buffer-read-only: t -*- vi:set ro: */
/* Disassembler interface for targets using CGEN. -*- C -*-
CGEN: Cpu tools GENerator