This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [gold][aarch64]: Fixing gold pr/21491 - Errata workaround can produce broken images.
- From: Cary Coutant <ccoutant at gmail dot com>
- To: Han Shen <shenhan at google dot com>
- Cc: binutils <binutils at sourceware dot org>, Peter Smith <peter dot smith at linaro dot org>, Eric Christopher <echristo at gmail dot com>, Jing Yu <jingyu at google dot com>, Luis Lozano <llozano at google dot com>, Caroline Tice <cmtice at google dot com>, Rahul Chaudhry <rahulchaudhry at google dot com>
- Date: Mon, 10 Jul 2017 21:41:17 -0700
- Subject: Re: [gold][aarch64]: Fixing gold pr/21491 - Errata workaround can produce broken images.
- Authentication-results: sourceware.org; auth=none
- References: <CACkGtrgGO2ToZ1T-9kr7Uu2XnqVp8qhgH_N4=chaJOi__fZO0w@mail.gmail.com> <CACkGtrjAa0jyeqsrQ4txew1zy_2jUDRH2WfW2sm4CSo=-v-bsw@mail.gmail.com> <CAJimCsGwJbEyAyRuf++3nbmu0hWRxMA3hGcACsXDOv1ghjrHOA@mail.gmail.com> <CACkGtrj_yZ=7LLntAn8DifasVJmiLK-WyWEc8RoT_=K_VAo_QQ@mail.gmail.com>
> gold/ChangeLog:
>
> 2017-07-06 Han Shen <shenhan@google.com>
> * aarch64.cc (Erratum_stub::invalidate_erratum_stub): New method.
> (Erratum_stub::is_invalidated_erratum_stub): New method.
> (Stub_table::relocate_reloc_stub): Renamed from "relocate_stub".
> (Stub_table::relocate_reloc_stubs): Renamed from "relocate_stubs".
> (Stub_table::relocate_erratum_stub): New method.
> (AArch64_relobj::fix_errata_and_relocate_erratum_stubs): Renamed from
> "fix_errata".
> (Target_aarch64::relocate_reloc_stub): Renamed from "relocate_stub".
+ switch (estub->type())
+ {
+ case ST_E_843419:
+ case ST_E_835769:
The braces for the switch should be indented two spaces, but the case
labels remain where they are -- even with the indented braces.
+ // stub. Note, when erratumf ix is skipped (either because we
s/f ix/ fix/
OK with those changes. Thanks!
-cary