This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] ld: Early detection of orphans we know will be discarded
On Thu, Aug 24, 2017 at 12:48:17PM +0100, Andrew Burgess wrote:
> * Alan Modra <amodra@gmail.com> [2017-08-24 07:52:38 +0930]:
>
> > On Wed, Aug 23, 2017 at 04:47:30PM +0100, Andrew Burgess wrote:
> > > PR 21961
> > > * ldlang.c (lang_discard_section_p): New function.
> > > (lang_add_section): Checks moved out into new function, which is
> > > now called.
> > > (lang_place_orphans): Call lang_discard_section_p instead of
> > > duplicating some of the checks from lang_add_section.
> > > * testsuite/ld-elf/orphan-11.d: New file.
> > > * testsuite/ld-elf/orphan-11.ld: New file.
> > > * testsuite/ld-elf/orphan-11.s: New file.
> > > * testsuite/ld-elf/orphan-12.d: New file.
> > > * testsuite/ld-elf/orphan-12.s: New file.
> >
> > OK with a minor nit fixed.
>
> Thanks for the review. I've pushed this to master now.
>
> Am I OK to push this to the `binutils-2_29-branch` too? I broke this
> on master in commit `7bdf4127c38` which was after 2.28 but before
> 2.29.
Yes please.
--
Alan Modra
Australia Development Lab, IBM