This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] src-release.sh enable gold


On Thu, Sep 14, 2017 at 06:58:12PM +0930, Alan Modra wrote:
> On Wed, Sep 13, 2017 at 10:12:09AM -0700, Matt Rice wrote:
> > diff --git a/src-release.sh b/src-release.sh
> > index 64fa4c2..80c1c33 100755
> > --- a/src-release.sh
> > +++ b/src-release.sh
> > @@ -83,7 +83,7 @@ do_proto_toplev()
> >  	<Makefile.in >tmp
> >      mv -f tmp Makefile.in
> >      #
> > -    ./configure --target=i386-pc-linux-gnu
> > +    ./configure --target=i386-pc-linux-gnu --enable-gold --enable-ld
> >      $MAKE configure-host configure-target \
> >  	ALL_GCC="" ALL_GCC_C="" ALL_GCC_CXX="" \
> >  	CC_FOR_TARGET="$CC" CXX_FOR_TARGET="$CXX"
> 
> I committed this, thinking it is a good idea, then backed it out..
> What gave me cold feet is
> a) I probably shouldn't be reviewing src-release.sh, and
> b) It would make more sense to only add the --enable switches when the
> corresponding dirs were in $support_files.

Actually, your patch is still on master at the moment.  I'm about to
commit the following on top of it.  Tested by running src-release for
binutils, gas, gdb, and sim.  I'll leave it to Nick to decide whether
this should go on the branch.

----
Enable/disable various dirs in src-release.sh

gold needs to be enabled for a binutils release, but it's rather odd
to do so for gas, gdb or sim.  This patch passes various --enable and
--disable options depending on the directories being released.

	* src-release.sh (do_proto_toplev): Revert last patch.  Enable or
	disable binutils, gas, gdb, gold, gprof, ld, libdecnumber, readline,
	and sim depending on $tool and $support_files.  Echo configure line.

diff --git a/src-release.sh b/src-release.sh
index 80c1c33..5f15de3 100755
--- a/src-release.sh
+++ b/src-release.sh
@@ -82,8 +82,18 @@ do_proto_toplev()
 	-e '/^	install-texinfo /d' \
 	<Makefile.in >tmp
     mv -f tmp Makefile.in
-    #
-    ./configure --target=i386-pc-linux-gnu --enable-gold --enable-ld
+    # configure.  --enable-gold is needed to ensure .c/.h from .y are
+    # built in the gold dir.  The disables speed the build a little.
+    enables=
+    disables=
+    for dir in binutils gas gdb gold gprof ld libdecnumber readline sim; do
+	case " $tool $support_files " in
+	    *" $dir "*) enables="$enables --enable-$dir" ;;
+	    *) disables="$disables --disable-$dir" ;;
+	esac
+    done
+    echo "==> configure --target=i386-pc-linux-gnu $disables $enables"
+    ./configure --target=i386-pc-linux-gnu $disables $enables
     $MAKE configure-host configure-target \
 	ALL_GCC="" ALL_GCC_C="" ALL_GCC_CXX="" \
 	CC_FOR_TARGET="$CC" CXX_FOR_TARGET="$CXX"

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]